Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bar chart labels X-position calculations #4566

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

rosco54
Copy link
Contributor

@rosco54 rosco54 commented Jul 11, 2024

New Pull Request

Although this change fixes the example in the issue, and all other samples in the package and my private collection appear to render correctly, it will have to be proven in use. I've attempted to base all computational changes on those first principals that the original code follows, as far as I understand them.

Fixes #4558

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@rosco54 rosco54 changed the title Fix bar chart totals labels X-position calculation Fix bar chart labels X-position calculations Jul 11, 2024
@rosco54 rosco54 marked this pull request as ready for review July 12, 2024 04:34
@junedchhipa junedchhipa merged commit da087c5 into apexcharts:main Jul 12, 2024
@rosco54 rosco54 deleted the Issue_4558 branch July 21, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bar chart - datalabels misaligned when using multiple y-axis
2 participants