Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated rollup-plugin-terser with @rollup/plugin-terser #4547

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

poteboy
Copy link
Contributor

@poteboy poteboy commented Jul 1, 2024

New Pull Request

The rollup-plugin-terser has not had a commit in four years, has been deprecated, and is no longer maintained. Therefore, I have replaced it with its successor, @rollup/plugin-terser.

Additionally, I noticed that the makeMap function, which was passed to the pure_funcs option, is not defined anywhere in the codebase (as verified by a grep search). Including such a function that is undefined and potentially has side effects in the future is error-prone. Hence, I have removed this option.

Other PRs (such as apexcharts#3709) have updated dependencies without performing a build. Following this precedent, this PR does not include an updated build.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes

@junedchhipa junedchhipa merged commit aed08a4 into apexcharts:main Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants