Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed theme change from dark mode to light mode not working #4505

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

Sebastian-Webster
Copy link
Contributor

@Sebastian-Webster Sebastian-Webster commented Jun 4, 2024

Fixed chart theme change from dark mode to light mode not working

Changing a chart from dark mode to light mode with the options object wasn't working (example at https://github.com/Sebastian-Webster/apex-reproducible-example)
This pull request fixes that issue so dark mode charts can be changed to light mode successfully

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@junedchhipa junedchhipa merged commit ba04441 into apexcharts:main Jun 13, 2024
@elucidsoft
Copy link

This should not have been merged in as it breaks transparent completely.

@Sebastian-Webster
Copy link
Contributor Author

The transparent background issue has been fixed in #4542

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants