Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default template does not validate against declared document type #52

Closed
aperezdc opened this issue Aug 30, 2016 · 2 comments
Closed

Default template does not validate against declared document type #52

aperezdc opened this issue Aug 30, 2016 · 2 comments
Assignees
@aperezdc
Labels
bug
Milestone
v0.4.2

Comments

@aperezdc
Copy link
Owner

The declared DOCTYPE in the default template is for XHTML, but the generated directory listings won't pass validation (Example.

Probably it does not make sense anymore to have a XHTML document type, and use the HTML5 one instead. Or, if compatibility is to be kept with very old browsers, “downgrade” the declared document type to HTML 4.01 Strict.

Information on document type declarations.
@aperezdc aperezdc added the bug label Aug 30, 2016
@aperezdc aperezdc added this to the v0.4.2 milestone Aug 30, 2016
@aperezdc aperezdc self-assigned this Aug 30, 2016
aperezdc added a commit that referenced this issue Aug 30, 2016
@aperezdc
Use the HTML5 document type declaration
a3a7626 
The XHTML document makes the document not to validate because of the undefined
entity references, and it seems better to use the HTML5 document type instead
of the HTML 4.01 one because the template uses already some modern constructs
like defining the device viewport options.

Fixes issue #52.
@aperezdc
Copy link
Owner Author

Also, the following are deprecated and cause validation errors:

  • cellpadding and cellspacing attributes in <table>.
  • <col width="...">

aperezdc added a commit that referenced this issue Aug 30, 2016
@aperezdc
Do not use col/colgroup tags in default template
bdaceb6 
Avoid using <colgroup> and <col> tags, which are deprecated in favour
of using CSS for styling.

See issue #52 for more information.
aperezdc added a commit that referenced this issue Aug 30, 2016
@aperezdc
Remove usage of cellpadding/cellspacing in default template
c5deb79 
This closes issue #52
@aperezdc
Copy link
Owner Author

The generated output now passes the W3C validator tests.

@sideshowbarker sideshowbarker mentioned this issue Sep 12, 2017
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aperezdc aperezdc

Labels
bug
Projects
None yet
Milestone
v0.4.2
Development

No branches or pull requests
1 participant
@aperezdc