-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Second parameter to fancyindex_header
/fancyindex_footer
is not always optional
#117
Comments
This comment has been minimized.
This comment has been minimized.
I have solved the problem. This is my config:
look this snippet: ngx-fancyindex/ngx_http_fancyindex_module.c Lines 231 to 240 in f52bace
|
This is definitely a bug. The intention was to make |
@cschug @bubbleatgit: release 0.5.1 is now available, and it includes the fix for this bug. |
@aperezdc LGTM, both issues, the optionalness of the second parameter as well as the error reporting in case of a unknown header/footer kind are fixed in 0.5.1. Thanks a lot for this quick fix and overall for this really, really helpful module ... very much appreciated! |
I just gave version 0.5.0 a spin but my configuration breaks with following error message:
if the order of directives is like that
If I swap those lines, the configuration validates and loads (init issue?).
And the even more curious thing is that
/tools/memdisk
mentioned in the error message isn't even part of theserver
stanza where fancyindex is being used. But it is rather the last location of theserver
stanza defined before theserver
in question. I have no idea how Nginx works internally but this seems off-by-one if all locations are indexed sequentially.This is Nginx 1.18.0 (self-compiled) on a CentOS 8 box. For now I will always specify the second parameter.
The text was updated successfully, but these errors were encountered: