Validate Content-Length headers for incoming requests #3231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[approve ci debian] |
zwoop
requested changes
Mar 5, 2018
proxy/hdrs/HTTP.cc
Outdated
|
|
||
| if ((content_length_len != content_length_len_2) || | ||
| (memcmp(content_length_val, content_length_val_2, content_length_len) != 0)) { | ||
| // Delete the duplicate since it has the same value |
There was a problem hiding this comment.
This comment looks wrong? In this case, you are returning a parse error, not removing the dupe, right?
There was a problem hiding this comment.
yeah, the comment is wrong
duplicate copies of the Content-Length header with exactly same values, and remove Content-Length headers if Transfer-Encoding header exists.
bryancall
force-pushed
the
content_length
branch
from
dd4f236
to
c54b47b
Compare
zwoop
approved these changes
Mar 6, 2018
|
Cherry-picked to 7.1.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Respond with 400 code when Content-Length headers mismatch, remove
duplicate copies of the Content-Length header with exactly same values,
and remove Content-Length headers if Transfer-Encoding header exists.