Return 400 if there is whitespace after the field name and before the colon #3192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryancall
force-pushed
the
field_name_whitespace
branch
from
f2ccd84
to
2eb04a7
Compare
zwoop
reviewed
Feb 28, 2018
| @@ -496,7 +496,7 @@ HdrTest::test_mime() | |||
| "continuation: part1\r\n" | |||
| " part2\r\n" | |||
| "scooby: doo\r\n" | |||
| "scooby : doo\r\n" | |||
There was a problem hiding this comment.
I think there's a way to have headers that should fail the parsing too, right? Maybe move the failure one there?
zwoop
approved these changes
Feb 28, 2018
|
Cherry-picked to 7.1.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
colon