Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change number format to original value to "~g" #9608

Merged
merged 1 commit into from
Apr 22, 2020
Merged

fix: change number format to original value to "~g" #9608

merged 1 commit into from
Apr 22, 2020

Commits on Apr 22, 2020

  1. fix: change number format to original value to "~g" 

    Originally it uses " ", which do give the original value, but will
not work when the `getNumberFormatter` in `superset-ui/number-format`
is called for the second time. Because the format will successfully
register as "" [1], but cannot be obtained again via `registry.get()`[2].

[1]: https://github.com/apache-superset/superset-ui/blob/44ad062dd02d080362dac28782c0327cc9fa3445/packages/superset-ui-number-format/src/NumberFormatterRegistry.ts#L30
[2]: https://github.com/apache-superset/superset-ui/blob/dc804b7a707e0cb8c29fc129bfff2c9aa143fd62/packages/superset-ui-core/src/models/RegistryWithDefaultKey.ts#L36
    @ktmud
    ktmud committed Apr 22, 2020
    Configuration menu
    Copy the full SHA
    3d33904 View commit details
    Browse the repository at this point in the history