Only list tables in DB test if API returns them (which it doesn't)

[rusackas]

…ever will)

CATEGORY

Choose one

• Bug Fix
• Enhancement (new features, refinement)
• Refactor
• Add tests
• Build / Development Environment
• Documentation

SUMMARY

I noticed that when you use the button to test a DB connection, the API just responds with "OK" and not a list of tables. That may be an issue worth exploring, or maybe it was changed for a good reason. In any case, there was some Javascript that was bugging out in trying to process/display a list of tables from that "OK" so I made this display logic conditional, such that it will only run if an array of tables is indeed returned. I doubt that will ever happen, but at least this PR kills the console error in any case.

REVIEWERS

@mistercrunch

[mistercrunch]

That original feature that shows the table name is a weird artifact from super early (like during the original hackathon) debugging. We could deprecate that.

[rusackas]

That original feature that shows the table name is a weird artifact from super early (like during the original hackathon) debugging. We could deprecate that.

Ok... given that, I just took that code out instead of wrapping it in a conditional. If we need to display tables, I'm guessing we'll go a different (e.g. React) direction with it anyway, rather than building on the jQuery stuff :)

[codecov-io]

Codecov Report

Merging #8681 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8681   +/-   ##
=======================================
  Coverage   65.77%   65.77%           
=======================================
  Files         481      481           
  Lines       23830    23830           
  Branches     2593     2593           
=======================================
  Hits        15674    15674           
  Misses       7983     7983           
  Partials      173      173

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f355548...6c6df6e. Read the comment docs.