Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[examples] Fix, sf population polygons div by zero error #8209

Merged
merged 1 commit into from
Sep 10, 2019
Merged

[examples] Fix, sf population polygons div by zero error #8209

merged 1 commit into from
Sep 10, 2019

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Sep 10, 2019 •
edited
Loading

CATEGORY

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Chart SF population polygons causes a division by zero error, this is caused by the conversion of the float type area field for zipcode 94104.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
Screenshot from 2019-09-10 06-13-55

After:
Screenshot from 2019-09-10 06-11-19

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

dpgaspar
dpgaspar commented Sep 10, 2019
View reviewed changes
superset/examples/sf_population_polygons.py
@@ -43,7 +43,7 @@ def load_sf_population_polygons(only_metadata=False, force=False):
"zipcode": BigInteger,
"population": BigInteger,
"contour": Text,
"area": BigInteger,
"area": Float,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The data contains:

{"zipcode":94104,"population":406,"area":0.18, ...

@mistercrunch mistercrunch merged commit 83f7038 into apache:master Sep 10, 2019
@mistercrunch mistercrunch deleted the fix/sf_population_polygons branch September 10, 2019 16:53
@villebro villebro added the v0.34 label Sep 27, 2019
villebro pushed a commit that referenced this pull request Sep 27, 2019
@dpgaspar @villebro
[examples] Fix, sf population polygons div by zero error (#8209)
e81f374
@prosdev0107 prosdev0107 mentioned this pull request Jun 14, 2022
Merged
9 tasks
@mistercrunch mistercrunch added 🍒 0.34.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.35.0 labels Feb 28, 2024
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@dpgaspar @villebro
[examples] Fix, sf population polygons div by zero error (apache#8209)
dd593c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v0.34 🍒 0.34.1 🚢 0.35.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dpgaspar @mistercrunch @villebro