Set disableErrorBoundary in SuperChart to fix chart error handling #8052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michellethomas
added
the
!deprecated-label:bug
kristw
approved these changes
Aug 15, 2019
Codecov Report
@@ Coverage Diff @@
## master #8052 +/- ##
==========================================
+ Coverage 65.56% 65.56% +<.01%
==========================================
Files 469 469
Lines 22480 22482 +2
Branches 2442 2444 +2
==========================================
+ Hits 14739 14741 +2
Misses 7621 7621
Partials 120 120
Continue to review full report at Codecov.
|
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Aug 16, 2019
…pache#8052) (cherry picked from commit ef1d4a6)
6 tasks
mistercrunch
added
🍒 0.34.1
🏷️ bot
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
There's a bug where if you get a chart error, fix the controls, and hit "Run Query", the chart doesn't update and get rid of the error. I noticed this on the Time Series Table, if I switch from a line chart to time series table and try to add an item, a chart error appears before I update that control correctly, after it's fixed and I "run query" the chart does not update (the same error appears).
This fixes the issue with error handling, but we should have another PR that more gracefully handles the time series table errors.
TEST PLAN
Open a line chart, change visualization type to time series table
Add an item under "Time Series Columns"
See error in chart
Correctly fill in column configuration info in Time Series Column
Run Query (chart should show up correctly)
ADDITIONAL INFORMATION
REVIEWERS
@graceguo-supercat @kristw @etr2460