Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: onSave datasource raises React error #8049

Merged
merged 2 commits into from
Aug 15, 2019

Conversation

mistercrunch
Copy link
Member

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

When saving a datasource in the explore view, React throws up

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2019-08-14 at 2 36 23 PM

TEST PLAN

Wrote a unit test to make sure React doesn't fail when props are null

@codecov-io
Copy link

Codecov Report

Merging #8049 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8049      +/-   ##
==========================================
+ Coverage   65.56%   65.56%   +<.01%     
==========================================
  Files         469      469              
  Lines       22480    22482       +2     
  Branches     2442     2444       +2     
==========================================
+ Hits        14739    14741       +2     
  Misses       7621     7621              
  Partials      120      120
Impacted Files Coverage Δ
...src/explore/components/controls/MetricsControl.jsx 80.13% <100%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed8bb1b...055eaa9. Read the comment docs.

@mistercrunch mistercrunch merged commit 5e0c91e into apache:master Aug 15, 2019
@mistercrunch mistercrunch deleted the fix_save_datasource branch August 15, 2019 21:13
@villebro villebro added the v0.34 label Aug 31, 2019
@mistercrunch mistercrunch added 🍒 0.34.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.35.0 labels Feb 28, 2024
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
* fix: datasource save raises React error

* add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S v0.34 🍒 0.34.1 🚢 0.35.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants