Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable flaky cypress test #8039

Merged
merged 1 commit into from
Aug 14, 2019
Merged

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Aug 13, 2019

No test is better than a flaky test...

ref: https://travis-ci.org/mistercrunch/superset/jobs/571524160

  1) Dashboard top-level controls should allow dashboard level force refresh:
     CypressError: Timed out retrying: expected '<li>' to have class 'disabled'
      at Object.cypressErr (http://localhost:8081/__cypress/runner/cypress_runner.js:65283:11)
      at Object.throwErr (http://localhost:8081/__cypress/runner/cypress_runner.js:65248:18)
      at Object.throwErrByPath (http://localhost:8081/__cypress/runner/cypress_runner.js:65275:17)
      at retry (http://localhost:8081/__cypress/runner/cypress_runner.js:58816:16)
      at http://localhost:8081/__cypress/runner/cypress_runner.js:50924:18
      at tryCatcher (http://localhost:8081/__cypress/runner/cypress_runner.js:127195:23)
      at Promise._settlePromiseFromHandler (http://localhost:8081/__cypress/runner/cypress_runner.js:125213:31)
      at Promise._settlePromise (http://localhost:8081/__cypress/runner/cypress_runner.js:125270:18)
      at Promise._settlePromise0 (http://localhost:8081/__cypress/runner/cypress_runner.js:125315:10)
      at Promise._settlePromises (http://localhost:8081/__cypress/runner/cypress_runner.js:125390:18)
      at Async._drainQueue (http://localhost:8081/__cypress/runner/cypress_runner.js:122119:16)
      at Async._drainQueues (http://localhost:8081/__cypress/runner/cypress_runner.js:122129:10)
      at Async.drainQueues (http://localhost:8081/__cypress/runner/cypress_runner.js:122003:14)
      at <anonymous>

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

ref: https://travis-ci.org/mistercrunch/superset/jobs/571524160
```
  1) Dashboard top-level controls should allow dashboard level force refresh:
     CypressError: Timed out retrying: expected '<li>' to have class 'disabled'
      at Object.cypressErr (http://localhost:8081/__cypress/runner/cypress_runner.js:65283:11)
      at Object.throwErr (http://localhost:8081/__cypress/runner/cypress_runner.js:65248:18)
      at Object.throwErrByPath (http://localhost:8081/__cypress/runner/cypress_runner.js:65275:17)
      at retry (http://localhost:8081/__cypress/runner/cypress_runner.js:58816:16)
      at http://localhost:8081/__cypress/runner/cypress_runner.js:50924:18
      at tryCatcher (http://localhost:8081/__cypress/runner/cypress_runner.js:127195:23)
      at Promise._settlePromiseFromHandler (http://localhost:8081/__cypress/runner/cypress_runner.js:125213:31)
      at Promise._settlePromise (http://localhost:8081/__cypress/runner/cypress_runner.js:125270:18)
      at Promise._settlePromise0 (http://localhost:8081/__cypress/runner/cypress_runner.js:125315:10)
      at Promise._settlePromises (http://localhost:8081/__cypress/runner/cypress_runner.js:125390:18)
      at Async._drainQueue (http://localhost:8081/__cypress/runner/cypress_runner.js:122119:16)
      at Async._drainQueues (http://localhost:8081/__cypress/runner/cypress_runner.js:122129:10)
      at Async.drainQueues (http://localhost:8081/__cypress/runner/cypress_runner.js:122003:14)
      at <anonymous>
```
Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for finding this and disabling it!

...looks like there was another flaky test on this PR though...

@mistercrunch mistercrunch merged commit 40c21dc into apache:master Aug 14, 2019
@mistercrunch mistercrunch deleted the disable_flaky branch August 14, 2019 14:45
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.35.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.35.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants