Remove collation info from MSSQL column type #7963
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
MSSQL columns can have lengthy types due to collations, for example
NVARCHAR(50) COLLATE SQL_LATIN1_GENERAL_CP1_CI_AS
, exceeding the 32 character limit in Superset. This PR copies logic from the MySQL spec which removes the unnecessary collation info.TEST PLAN
Test locally
ADDITIONAL INFORMATION
REVIEWERS
@vitorbellini @syazwan0913