Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] html points to dashboard.entry.js instead of jsx #749

Merged
merged 1 commit into from
Jul 13, 2016

Conversation

mistercrunch
Copy link
Member

@georgeke @ascott , I needed to change that to get things working after I rebased a branch. I'm confused as to how it worked on your side @georgeke, maybe different version of webpack have different rules as to generating a .js vs .jsx?

@coveralls
Copy link

coveralls commented Jul 12, 2016

Coverage Status

Coverage remained the same at 81.114% when pulling b248cec on mistercrunch:fix_dashboard_jsx into 18b8e6f on airbnb:master.

@georgeke
Copy link
Contributor

@mistercrunch when I was developing dashboard.jsx the webpack was outputting js files (filename: '[name].entry.js') so this change wasn't needed. I think the correct fix may be to switch the output files back to .js. It was my understanding that our built files should be pure js, I'm not sure on why they are .jsx?

@ascott do you have any thoughts on this?

@mistercrunch
Copy link
Member Author

On my side it now builds to jsx.
screen shot 2016-07-12 at 11 19 42 pm

webpack 1.13.0
$ node -v
v5.10.1
$ npm -v
3.8.3

@mistercrunch
Copy link
Member Author

It seems to be the same (jsx) on the Travis build

@mistercrunch
Copy link
Member Author

A recent pull request from x4base also made this fix. Since master is broken as far as travis would be concerned if it tested js, I'm merging this.

@mistercrunch mistercrunch merged commit 082645d into apache:master Jul 13, 2016
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants