[load_examples] download data at runtime #7314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running `superset load_examples` to load example data sets, Superset used to load from the local package. This created a few issues notably around licensing (what are these datasets licensed as?) and around package size. For now, I moved the data sets here: https://github.com/apache-superset/examples-data Altered the logic to download the data from where it is stored.
mistercrunch
force-pushed
the
remote_data
branch
from
7db504d
to
2a50665
Compare
Codecov Report
@@ Coverage Diff @@
## master #7314 +/- ##
==========================================
- Coverage 64.93% 64.91% -0.02%
==========================================
Files 424 424
Lines 20589 20580 -9
Branches 2281 2281
==========================================
- Hits 13369 13360 -9
Misses 7097 7097
Partials 123 123
Continue to review full report at Codecov.
|
1 task
mistercrunch
added a commit
that referenced
this pull request
Apr 19, 2019
* [load_examples] download data at runtime When running `superset load_examples` to load example data sets, Superset used to load from the local package. This created a few issues notably around licensing (what are these datasets licensed as?) and around package size. For now, I moved the data sets here: https://github.com/apache-superset/examples-data Altered the logic to download the data from where it is stored. * flakes (cherry picked from commit 3d08266)
mistercrunch
added
🏷️ bot
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
* [load_examples] download data at runtime When running `superset load_examples` to load example data sets, Superset used to load from the local package. This created a few issues notably around licensing (what are these datasets licensed as?) and around package size. For now, I moved the data sets here: https://github.com/apache-superset/examples-data Altered the logic to download the data from where it is stored. * flakes (cherry picked from commit 0088895)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
This PR will help us push our first Apache release.
When running
superset load_examplesto load example data sets,Superset used to load from the local package. This created a few issues
notably around licensing (what are these datasets licensed as?) and
around package size.
For now, I moved the data sets here https://github.com/apache-superset/examples-data
and altered the logic to download the data from where it is stored (another Github repo).
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TEST PLAN
Ran
superset load_examplesand validated examples look okREVIEWERS
@kristw