Fix erroneous options for default slices #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage decreased (-0.02%) to 81.011% when pulling 57b981ae388be8ffc8c0a37a5d21be6063f8846c on georgeke:default-slice-fixes into afff788 on airbnb:master. |
georgeke
force-pushed
the
default-slice-fixes
branch
from
57b981a
to
38526c1
Compare
|
lgtm. wonder if we could add a test to catch this... |
|
Nice! |
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
1. move translation, connection, query to core (apache#729) 2. update encodable to remove formatter inter-dependency (apache#744) 3. move number-format and time-format to core (apache#730) 4. move superset-ui/dimension to core (apache#732) 5. move superset-ui/color to core (apache#755) 6. move superset-ui/style to core (apache#756) 7. move superset-ui/validator to core (apache#757) 8. move superset-ui/chart-composition to core (apache#759) 9. move superset-ui/chart to core (apache#760)
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
1. move translation, connection, query to core (apache#729) 2. update encodable to remove formatter inter-dependency (apache#744) 3. move number-format and time-format to core (apache#730) 4. move superset-ui/dimension to core (apache#732) 5. move superset-ui/color to core (apache#755) 6. move superset-ui/style to core (apache#756) 7. move superset-ui/validator to core (apache#757) 8. move superset-ui/chart-composition to core (apache#759) 9. move superset-ui/chart to core (apache#760)
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
1. move translation, connection, query to core (apache#729) 2. update encodable to remove formatter inter-dependency (apache#744) 3. move number-format and time-format to core (apache#730) 4. move superset-ui/dimension to core (apache#732) 5. move superset-ui/color to core (apache#755) 6. move superset-ui/style to core (apache#756) 7. move superset-ui/validator to core (apache#757) 8. move superset-ui/chart-composition to core (apache#759) 9. move superset-ui/chart to core (apache#760)
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
1. move translation, connection, query to core (apache#729) 2. update encodable to remove formatter inter-dependency (apache#744) 3. move number-format and time-format to core (apache#730) 4. move superset-ui/dimension to core (apache#732) 5. move superset-ui/color to core (apache#755) 6. move superset-ui/style to core (apache#756) 7. move superset-ui/validator to core (apache#757) 8. move superset-ui/chart-composition to core (apache#759) 9. move superset-ui/chart to core (apache#760)
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorrect
granularity_sqlafield in multiformat slices due to columns not havingis_dttm=True.Parallel coordinates using an array for
series