Adding template_params to datasource editor for sqla tables #6869
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a sqla table previously had template_params, saving changes in the datasource editor will override template_params. To fix this, I'm adding the template_params field to the "Advanced" section of the table editor.
Tested by:
Created a sqllab datasource based on birth names with jinja params.
Edited the template_params using the datasource editor and confirmed that the param was getting updated.
@mistercrunch @graceguo-supercat @john-bodley