[sqla] Fixing order-by for non-inner-joins #6862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
force-pushed
the
john-bodley--orderby-debug
branch
2 times, most recently
from
c85f0dd
to
8a45d56
Compare
Codecov Report
@@ Coverage Diff @@
## master #6862 +/- ##
==========================================
+ Coverage 56.22% 56.32% +0.09%
==========================================
Files 527 527
Lines 23529 23534 +5
Branches 2782 2782
==========================================
+ Hits 13229 13255 +26
+ Misses 9888 9867 -21
Partials 412 412
Continue to review full report at Codecov.
|
john-bodley
added
!deprecated-label:bug
john-bodley
force-pushed
the
john-bodley--orderby-debug
branch
from
8a45d56
to
0f190ad
Compare
michellethomas
approved these changes
Feb 15, 2019
john-bodley
added a commit
that referenced
this pull request
Feb 15, 2019
(cherry picked from commit 5728946)
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Mar 18, 2019
(cherry picked from commit 5728946)
9 tasks
mistercrunch
added
🏷️ bot
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
(cherry picked from commit 5728946)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue for sort-by in timeseries when using a non-inner-join SQL dialect e.g. Druid. Previously the subquery was using the main metric in the order by rather than adhering to the time series limit query if present.
to: @betodealmeida @michellethomas @mistercrunch