add error details into log #6169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graceguo-supercat
changed the title
Codecov Report
@@ Coverage Diff @@
## master #6169 +/- ##
=======================================
Coverage 76.91% 76.91%
=======================================
Files 47 47
Lines 9362 9362
=======================================
Hits 7201 7201
Misses 2161 2161Continue to review full report at Codecov.
|
graceguo-supercat
changed the title
graceguo-supercat
force-pushed
the
gg-AddErrorMsgToLogging
branch
from
6aa8064
to
31344db
Compare
graceguo-supercat
force-pushed
the
gg-AddErrorMsgToLogging
branch
from
31344db
to
cc9c9cc
Compare
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Oct 25, 2018
(cherry picked from commit 9c5fc42)
bipinsoniguavus
pushed a commit
to ThalesGroup/incubator-superset
that referenced
this pull request
Dec 26, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add error_details attribute into log. will help us differentiate number of timeout/python errro/render error etc.
@williaster @michellethomas @mistercrunch @kristw