[SIP-5&6] Refactor line_multi #6058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6058 +/- ##
=======================================
Coverage 77.56% 77.56%
=======================================
Files 47 47
Lines 9484 9484
=======================================
Hits 7356 7356
Misses 2128 2128Continue to review full report at Codecov.
|
conglei
reviewed
Oct 16, 2018
| // add null values at the edges to fix multiChart bug when series with | ||
| // different x values use different y axes | ||
| if (lineCharts.length && lineCharts2.length) { | ||
| let minx = Infinity; |
There was a problem hiding this comment.
nit: minX, maxX, minY, maxY are more readable
conglei
approved these changes
Oct 16, 2018
|
LGTM |
bipinsoniguavus
pushed a commit
to ThalesGroup/incubator-superset
that referenced
this pull request
Dec 26, 2018
* Rewrite line_multi * move dir * add chartplugin for line_multi * rename var
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate the code for
line_multito remove dependency fromsliceand convert to react components with similar interface with the others.Add
ChartPluginforline_multisimilar to Add ChartPlugin and metadata for nvd3 and BigNumber vis #6085Also fix the potential bug that part of the
filtersare not applied.There was this line in the original code:
This line does not mutate the
filters. On a quick pass it might seemsfd.filtersis concatenated to andfiltersis modified while in fact it returns a new concatenated array as a result, which was not received by any variable.@williaster @conglei @graceguo-supercat @michellethomas