[cleanup] Remove future imports from tests and utils #6050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timifasubaa
changed the title
timifasubaa
force-pushed
the
remove_future_imports
branch
2 times, most recently
from
d644db7
to
5990431
Compare
john-bodley
reviewed
Oct 9, 2018
tests/druid_func_tests.py
Outdated
| @@ -33,6 +28,8 @@ def emplace(metrics_dict, metric_name, is_postagg=False): | |||
| # Unit tests that can be run without initializing base tests | |||
| class DruidFuncTestCase(unittest.TestCase): | |||
|
|
|||
| _multiprocess_can_split_ = True | |||
There was a problem hiding this comment.
Is this supposed to be here?
timifasubaa
force-pushed
the
remove_future_imports
branch
from
5990431
to
b0b237f
Compare
timifasubaa
force-pushed
the
remove_future_imports
branch
from
b0b237f
to
e555d99
Compare
timifasubaa
changed the title
timifasubaa
changed the title
Codecov Report
@@ Coverage Diff @@
## master #6050 +/- ##
==========================================
- Coverage 77.81% 77.78% -0.03%
==========================================
Files 46 46
Lines 9446 9434 -12
==========================================
- Hits 7350 7338 -12
Misses 2096 2096
Continue to review full report at Codecov.
|
|
PING |
john-bodley
approved these changes
Oct 11, 2018
john-bodley
requested changes
Oct 11, 2018
|
I chunked it into smaller pieces so it's easier to review. This PR only covers the tests. The other PRs cover the other parts. |
john-bodley
approved these changes
Oct 11, 2018
bipinsoniguavus
pushed a commit
to ThalesGroup/incubator-superset
that referenced
this pull request
Dec 26, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we now no longer support python2, This PR starts taking out the future imports from tests and utils.
I will follow up with the same thing for other parts of the code base and also do the same for six and utf8.
@john-bodley @mistercrunch