Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIP-6] Migrate visualizations to new directory structure (part 3 - nvd3) #6006

Merged
merged 2 commits into from
Oct 3, 2018

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Sep 28, 2018

In this PR
nvd3

Included in PR #5997 (part 2)
BigNumber
MapBox
TimeTable
EventFlow

Remaining for next PR
iframe
markup
deck.gl

This can be reviewed in parallel with #5997. They do not conflict with or depend on each other.

@conglei @williaster

@kristw kristw changed the title [SIP-6] Migrate visualizations to new directory structure (part 3) [SIP-6] Migrate nvd3 to new directory structure (part 3) Sep 28, 2018
@kristw kristw changed the title [SIP-6] Migrate nvd3 to new directory structure (part 3) [SIP-6] Migrate visualizations to new directory structure (part 3 - nvd3) Sep 28, 2018
@kristw kristw closed this Sep 28, 2018
@kristw kristw reopened this Sep 28, 2018
@codecov-io
Copy link

codecov-io commented Sep 29, 2018

Codecov Report

Merging #6006 into master will increase coverage by 0.02%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6006      +/-   ##
==========================================
+ Coverage   63.48%   63.51%   +0.02%     
==========================================
  Files         443      446       +3     
  Lines       23753    23760       +7     
  Branches     2638     2638              
==========================================
+ Hits        15080    15090      +10     
+ Misses       8660     8657       -3     
  Partials       13       13
Impacted Files Coverage Δ
...perset/assets/src/visualizations/nvd3/LineMulti.js 0% <0%> (ø) ⬆️
...uperset/assets/src/visualizations/nvd3/adaptor.jsx 100% <100%> (ø)
superset/assets/src/visualizations/nvd3/NVD3Vis.js 7.82% <100%> (+0.06%) ⬆️
...perset/assets/src/visualizations/nvd3/ReactNVD3.js 100% <100%> (ø)
...t/assets/src/visualizations/nvd3/transformProps.js 21.42% <21.42%> (ø)
...ssets/src/visualizations/models/BasicChartInput.js 85.71% <50%> (-5.96%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36e2ddd...ed0694e. Read the comment docs.

Copy link
Contributor

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@williaster williaster merged commit 5c2a788 into apache:master Oct 3, 2018
@kristw kristw deleted the kristw-vis-dir3 branch October 3, 2018 17:27
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants