-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SIP-6] Migrate visualizations to new directory structure. #5949
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
4421c10
Migrate Chord, Calendar
kristw 57cedca
Migrate CountryMap
kristw d804eb2
Add display name and rename Chord.jsx to Chord.js
kristw a234e09
migrate Histogram
kristw a048c1b
add force-directed
kristw eec0d11
migrate Heatmap
kristw 246af99
add horizon
kristw a3d03e7
migrate parallel coordinates
kristw 28fc7c8
migrate partition
kristw 11bea48
migrate pivot table
kristw cfb0b90
migrate rose
kristw 33efef8
remove react-dom
kristw 371d144
migrate Sankey
kristw 127d0f4
migrate sunburst
kristw 0aa0aa5
migrate table
kristw a512ec2
migrate treemap
kristw b859e3d
migrate filterbox
kristw cead20e
migrate wordcloud
kristw 90ff8ef
add paired t-test
kristw 970eecf
fix unit test
kristw be3234f
remove renaming
kristw 5245497
rename fields
kristw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
import reactify from '../../utils/reactify'; | ||
import Component from './Calendar'; | ||
|
||
export default reactify(Component); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
import createAdaptor from '../../utils/createAdaptor'; | ||
import Component from './ReactCalendar'; | ||
import transformProps from './transformProps'; | ||
|
||
export default createAdaptor(Component, transformProps); |
32 changes: 32 additions & 0 deletions
32
superset/assets/src/visualizations/Calendar/transformProps.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
export default function transformProps(basicChartInput) { | ||
const { formData, payload, datasource } = basicChartInput; | ||
const { | ||
cellPadding, | ||
cellRadius, | ||
cellSize, | ||
linearColorScheme, | ||
showLegend, | ||
showMetricName, | ||
showValues, | ||
steps, | ||
xAxisTimeFormat, | ||
yAxisFormat, | ||
} = formData; | ||
|
||
const { verboseMap } = datasource; | ||
|
||
return { | ||
data: payload.data, | ||
cellPadding, | ||
cellRadius, | ||
cellSize, | ||
linearColorScheme, | ||
showLegend, | ||
showMetricName, | ||
showValues, | ||
steps, | ||
timeFormat: xAxisTimeFormat, | ||
valueFormat: yAxisFormat, | ||
verboseMap, | ||
}; | ||
} |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
import reactify from '../../utils/reactify'; | ||
import Component from './Chord'; | ||
|
||
export default reactify(Component); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
import createAdaptor from '../../utils/createAdaptor'; | ||
import Component from './ReactChord'; | ||
import transformProps from './transformProps'; | ||
|
||
export default createAdaptor(Component, transformProps); |
10 changes: 10 additions & 0 deletions
10
superset/assets/src/visualizations/Chord/transformProps.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
export default function transformProps(basicChartInput) { | ||
const { formData, payload } = basicChartInput; | ||
const { yAxisFormat, colorScheme } = formData; | ||
|
||
return { | ||
data: payload.data, | ||
numberFormat: yAxisFormat, | ||
colorScheme, | ||
}; | ||
} |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
superset/assets/src/visualizations/CountryMap/ReactCountryMap.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
import reactify from '../../utils/reactify'; | ||
import Component from './CountryMap'; | ||
|
||
export default reactify(Component); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
import createAdaptor from '../../utils/createAdaptor'; | ||
import Component from './ReactCountryMap'; | ||
import transformProps from './transformProps'; | ||
|
||
export default createAdaptor(Component, transformProps); |
15 changes: 15 additions & 0 deletions
15
superset/assets/src/visualizations/CountryMap/transformProps.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
export default function transformProps(basicChartInput) { | ||
const { formData, payload } = basicChartInput; | ||
const { | ||
linearColorScheme, | ||
numberFormat, | ||
selectCountry, | ||
} = formData; | ||
|
||
return { | ||
data: payload.data, | ||
country: selectCountry, | ||
linearColorScheme, | ||
numberFormat, | ||
}; | ||
} |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
import createAdaptor from '../../utils/createAdaptor'; | ||
import Component from './FilterBox'; | ||
import transformProps from './transformProps'; | ||
|
||
export default createAdaptor(Component, transformProps); |
39 changes: 39 additions & 0 deletions
39
superset/assets/src/visualizations/FilterBox/transformProps.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
export default function transformProps(basicChartInput) { | ||
const { | ||
datasource, | ||
filters, | ||
formData, | ||
onAddFilter, | ||
payload, | ||
rawDatasource, | ||
} = basicChartInput; | ||
const { | ||
dateFilter, | ||
groupby, | ||
instantFiltering, | ||
showDruidTimeGranularity, | ||
showDruidTimeOrigin, | ||
showSqlaTimeColumn, | ||
showSqlaTimeGranularity, | ||
} = formData; | ||
const { verboseMap } = datasource; | ||
|
||
const filtersFields = groupby.map(key => ({ | ||
key, | ||
label: verboseMap[key] || key, | ||
})); | ||
|
||
return { | ||
datasource: rawDatasource, | ||
filtersFields, | ||
filtersChoices: payload.data, | ||
instantFiltering, | ||
onChange: onAddFilter, | ||
origSelectedValues: filters || {}, | ||
showDateFilter: dateFilter, | ||
showDruidTimeGrain: showDruidTimeGranularity, | ||
showDruidTimeOrigin, | ||
showSqlaTimeColumn, | ||
showSqlaTimeGrain: showSqlaTimeGranularity, | ||
}; | ||
} |
File renamed without changes.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit. There are some inconsistencies on the name of
groupby
.In some chart, it is renamed asgroupBy
. it is better to make it consistent.