Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deck_polygon] implement null locations flag #5948

Merged
merged 2 commits into from
Sep 21, 2018

Conversation

mistercrunch
Copy link
Member

screen shot 2018-09-20 at 4 50 31 pm

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #5948 into master will decrease coverage by 14.18%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #5948       +/-   ##
===========================================
- Coverage   77.77%   63.59%   -14.19%     
===========================================
  Files          46      393      +347     
  Lines        9391    23670    +14279     
  Branches        0     2635     +2635     
===========================================
+ Hits         7304    15052     +7748     
- Misses       2087     8605     +6518     
- Partials        0       13       +13
Impacted Files Coverage Δ
superset/assets/src/explore/controls.jsx 46.66% <ø> (ø)
superset/viz.py 81.04% <100%> (+0.04%) ⬆️
superset/assets/src/components/Checkbox.jsx 100% <0%> (ø)
...ets/src/dashboard/components/dnd/DragDroppable.jsx 97.91% <0%> (ø)
superset/assets/src/components/EditableTitle.jsx 84.37% <0%> (ø)
...src/explore/components/controls/VizTypeControl.jsx 89.58% <0%> (ø)
...t/assets/src/components/InfoTooltipWithTrigger.jsx 58.82% <0%> (ø)
.../src/dashboard/components/UndoRedoKeylisteners.jsx 44% <0%> (ø)
...ts/src/explore/components/ExploreActionButtons.jsx 100% <0%> (ø)
...sets/src/dashboard/components/DashboardBuilder.jsx 92.75% <0%> (ø)
... and 341 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73d1e45...c9b5960. Read the comment docs.

@mistercrunch mistercrunch merged commit a1fa4bc into apache:master Sep 21, 2018
@mistercrunch mistercrunch deleted the ignore_null_geohash branch September 21, 2018 05:02
@kristw kristw mentioned this pull request Sep 21, 2018
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
* [deck_polygon] implement null locations flag

* Fix unrelated JS test issue
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants