Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] Remove dependency on personal fork of supercluster from mapbox visualizations #5902

Merged
merged 2 commits into from
Sep 18, 2018
Merged

[refactor] Remove dependency on personal fork of supercluster from mapbox visualizations #5902

merged 2 commits into from
Sep 18, 2018

Commits on Sep 18, 2018

  1. [refactor] Remove dependency to personal fork of supercluster from ma… 

    …pbox visualizations

- Update dependency to reference the vanilla supercluster
- Clean up backend api call for mapbox vizzes to ensure a boolean is sent to indicate whether the viz includes custom metric for clustering
- Refactor of mapbox and its cluster overlay components to use vanilla supercluster and its recommeded way for handling clustering based on custom aggregations.
- Allow reclustering within the initial bounds on render in mapbox visualizations (stay true to old behaviors).
- Remove the median aggregation from available cluster label aggregators as there is no memory efficient way to implement this and it is unknown how often this feature is used
- Updating doc to mention the backward incompatible change re median
    @xtinec
    xtinec committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    6284b57 View commit details
    Browse the repository at this point in the history

  2. Perform the check for has_custom_metric through not None to produce… 

    … a boolean and rename the field reflect it is a boolean.
    @xtinec
    xtinec committed Sep 18, 2018
    Configuration menu
    Copy the full SHA
    55a1955 View commit details
    Browse the repository at this point in the history