Get 'Test Connection' button to take 'engine_params' into account #5830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5830 +/- ##
=========================================
+ Coverage 63.7% 63.7% +<.01%
=========================================
Files 366 366
Lines 23143 23144 +1
Branches 2599 2599
=========================================
+ Hits 14744 14745 +1
Misses 8384 8384
Partials 15 15
Continue to review full report at Codecov.
|
john-bodley
reviewed
Sep 6, 2018
john-bodley
approved these changes
Sep 7, 2018
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
…ache#5830) (cherry picked from commit 4a62ef3)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
…ache#5830) (cherry picked from commit 4a62ef3)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
…ache#5830) (cherry picked from commit 4a62ef3)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
…ache#5830) (cherry picked from commit 4a62ef3)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
…ache#5830) (cherry picked from commit 4a62ef3)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
…ache#5830) (cherry picked from commit 4a62ef3)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
…ache#5830) (cherry picked from commit 4a62ef3)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
…ache#5830) (cherry picked from commit 4a62ef3)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
…ache#5830) (cherry picked from commit 4a62ef3)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 11, 2018
…ache#5830) (cherry picked from commit 4a62ef3)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 11, 2018
…ache#5830) (cherry picked from commit 4a62ef3)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 11, 2018
…ache#5830) (cherry picked from commit 4a62ef3)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
…ache#5830) (cherry picked from commit 4a62ef3)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
…ache#5830) (cherry picked from commit 4a62ef3)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 17, 2018
…ache#5830) (cherry picked from commit 4a62ef3)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 17, 2018
…ache#5830) (cherry picked from commit 4a62ef3)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 17, 2018
…ache#5830) (cherry picked from commit 4a62ef3)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 17, 2018
…ache#5830) (cherry picked from commit 4a62ef3)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 17, 2018
…ache#5830) (cherry picked from commit 4a62ef3)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 29, 2018
…ache#5830) (cherry picked from commit 4a62ef3)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
…ache#5830) (cherry picked from commit 4a62ef3)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
…ache#5830) (cherry picked from commit 4a62ef3)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
…ache#5830) (cherry picked from commit 4a62ef3)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
…ache#5830) (cherry picked from commit 4a62ef3)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
…ache#5830) (cherry picked from commit 4a62ef3)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Nov 2, 2018
…ache#5830) (cherry picked from commit 4a62ef3)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Nov 2, 2018
…ache#5830) (cherry picked from commit 4a62ef3)
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was connecting BigQuery and realized that the 'Test Connection' was disregarding the
extrasparameters. This addressed it: