-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bugfix] IS NOT NULL filter triggers KeyError: 'val' #5764
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mistercrunch
commented
Aug 28, 2018
betodealmeida
approved these changes
Aug 28, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
We should at some point improve the metric component so that the value input is disabled when IS NULL
and IS NOT NULL
are selected.
+1 @hughhhh ^^^ |
@mistercrunch @hughhhh I have a PR fixing the UI for this, will send for review. Edit: #5766 |
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
(cherry picked from commit 6c6ea37)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
(cherry picked from commit 6c6ea37)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
(cherry picked from commit 6c6ea37)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
(cherry picked from commit 6c6ea37)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
(cherry picked from commit 6c6ea37)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
(cherry picked from commit 6c6ea37)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
(cherry picked from commit 6c6ea37)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
(cherry picked from commit 6c6ea37)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
(cherry picked from commit 6c6ea37)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
(cherry picked from commit 6c6ea37)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Sep 21, 2018
(cherry picked from commit 6c6ea37)
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Oct 9, 2018
(cherry picked from commit 6c6ea37)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 11, 2018
(cherry picked from commit 6c6ea37)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 11, 2018
(cherry picked from commit 6c6ea37)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 11, 2018
(cherry picked from commit 6c6ea37)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
(cherry picked from commit 6c6ea37)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 12, 2018
(cherry picked from commit 6c6ea37)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 17, 2018
(cherry picked from commit 6c6ea37)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 17, 2018
(cherry picked from commit 6c6ea37)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 17, 2018
(cherry picked from commit 6c6ea37)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 17, 2018
(cherry picked from commit 6c6ea37)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 17, 2018
(cherry picked from commit 6c6ea37)
mistercrunch
added a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 29, 2018
(cherry picked from commit 6c6ea37)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
(cherry picked from commit 6c6ea37)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
(cherry picked from commit 6c6ea37)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
(cherry picked from commit 6c6ea37)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
(cherry picked from commit 6c6ea37)
betodealmeida
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Oct 30, 2018
(cherry picked from commit 6c6ea37)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Nov 2, 2018
(cherry picked from commit 6c6ea37)
youngyjd
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Nov 2, 2018
(cherry picked from commit 6c6ea37)
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels
🚢 0.28.0
labels
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.