Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return 403 on no authorization #5716

Merged
merged 2 commits into from
Aug 24, 2018
Merged

Return 403 on no authorization #5716

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9827925
Return 401 on no authorization
betodealmeida Aug 24, 2018
c567a89
Use 403
betodealmeida Aug 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions superset/views/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2340,7 +2340,7 @@ def results(self, key):
query.sql, query.database, query.schema)
if rejected_tables:
return json_error_response(security_manager.get_table_access_error_msg(
'{}'.format(rejected_tables)))
'{}'.format(rejected_tables)), status=403)

return json_success(utils.zlib_decompress_to_string(blob))

Expand Down Expand Up @@ -2383,7 +2383,8 @@ def sql_json(self):
if rejected_tables:
return json_error_response(
security_manager.get_table_access_error_msg(rejected_tables),
link=security_manager.get_table_access_link(rejected_tables))
link=security_manager.get_table_access_link(rejected_tables),
status=403)
session.commit()

select_as_cta = request.form.get('select_as_cta') == 'true'
Expand Down