Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make some text localizable #5611

Merged
merged 1 commit into from
Aug 13, 2018
Merged

make some text localizable #5611

merged 1 commit into from
Aug 13, 2018

Conversation

hitdemo
Copy link
Contributor

@hitdemo hitdemo commented Aug 12, 2018

there are some text can't be translated when switch languages, make them localizable.
in this PR, no modify for DraggableNewComponent

@codecov-io
Copy link

Codecov Report

Merging #5611 into master will increase coverage by 0.03%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5611      +/-   ##
==========================================
+ Coverage   63.59%   63.62%   +0.03%     
==========================================
  Files         359      359              
  Lines       22799    22820      +21     
  Branches     2533     2533              
==========================================
+ Hits        14499    14520      +21     
  Misses       8285     8285              
  Partials       15       15
Impacted Files Coverage Δ
superset/assets/src/explore/visTypes.jsx 57.14% <ø> (ø) ⬆️
...sets/src/explore/components/DisplayQueryButton.jsx 73.84% <ø> (ø) ⬆️
superset/connectors/sqla/views.py 64.34% <ø> (ø) ⬆️
superset/connectors/druid/views.py 68.24% <ø> (ø) ⬆️
...ore/components/controls/AnnotationLayerControl.jsx 38.46% <0%> (ø) ⬆️
superset/views/annotations.py 75.55% <100%> (+7.9%) ⬆️
...set/assets/src/dashboard/components/SliceAdder.jsx 86.04% <100%> (+0.16%) ⬆️
superset/views/core.py 73.99% <100%> (+0.15%) ⬆️
...rc/explore/components/controls/AnnotationLayer.jsx 23.03% <33.33%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1ef81f...5832fbb. Read the comment docs.

@mistercrunch mistercrunch merged commit 50981db into apache:master Aug 13, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants