[feature] Allow min/max value for the sparkline in time series table #5603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5603 +/- ##
==========================================
- Coverage 63.59% 63.48% -0.11%
==========================================
Files 359 360 +1
Lines 22799 22879 +80
Branches 2533 2546 +13
==========================================
+ Hits 14499 14525 +26
- Misses 8285 8339 +54
Partials 15 15
Continue to review full report at Codecov.
|
|
Add an option to show bounds
|
|
@kristw this looks great! One thought about the reference lines/showing the bounds, do you think it'd be useful to label them? Something like the following but just the number for min / max
The tricky thing with this would be the padding to accommodate the label, so might not be worth it 🤔 would be nice to have better support for that tho. |
|
Done 😄. Using
|
|
WOW! 🙉 this will also be really useful (possibly more so!) without setting ymin/max bounds too |
|
|
kristw
added a commit
to kristw/incubator-superset
that referenced
this pull request
Aug 14, 2018
…pache#5603) * Allow min/max value for the sparkline in time series table * show bound lines * User can choose to show y-axis bounds * show label for the bounds * compute necessary padding for the bound label * extract sparkline code to another component * can show y-axis in sparkline without setting bounds * reorder option rows (cherry picked from commit 536478e)
kristw
added a commit
to kristw/incubator-superset
that referenced
this pull request
Aug 14, 2018
…pache#5603) * Allow min/max value for the sparkline in time series table * show bound lines * User can choose to show y-axis bounds * show label for the bounds * compute necessary padding for the bound label * extract sparkline code to another component * can show y-axis in sparkline without setting bounds * reorder option rows (cherry picked from commit 536478e)
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
…pache#5603) * Allow min/max value for the sparkline in time series table * show bound lines * User can choose to show y-axis bounds * show label for the bounds * compute necessary padding for the bound label * extract sparkline code to another component * can show y-axis in sparkline without setting bounds * reorder option rows
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
time_tableintoSparklineCell@williaster @graceguo-supercat