-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sqllab] fix unexpected keyword argument 'ignore_nan' #5490
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5490 +/- ##
=======================================
Coverage 63.33% 63.33%
=======================================
Files 349 349
Lines 22099 22099
Branches 2455 2455
=======================================
Hits 13996 13996
Misses 8089 8089
Partials 14 14
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to standardize on always using simplejson
instead of json
, I noticed we use both. The former also has the advantage that it produces strict JSON compared to the latter.
(cherry picked from commit 6f87552)
(cherry picked from commit 6f87552)
(cherry picked from commit 6f87552)
(cherry picked from commit 6f87552)
(cherry picked from commit 6f87552)
(cherry picked from commit 6f87552)
(cherry picked from commit 6f87552)
(cherry picked from commit 6f87552)
[sqllab] fix unexpected keyword argument 'ignore_nan' (apache#5490)
fixes issue introduced by #5413
@john-bodley @timifasubaa