[fix] new dashboard state

[graceguo-supercat]

• new dashboard should always be V2, do not show preview message
• According to designer's feedback, if user create new dash/add chart to existed dash from explore view, should show dashboard in view mode.

[williaster]

@graceguo-supercat I had one suggestion for the edit mode flag.

also, does this fix the case of "save as"? ie if you "save as" for a v1 or v2 dashboard, is it v2?

[williaster]

I don't think we should ignore this here, I think it's better for it simply not to be set on explore view side.

[graceguo-supercat]

old dashboard needs this feature :)
we can remove after v1 => v2 transition time.

[williaster]

@graceguo-supercat why does it need that? can you not add a chart to a v1 dashboard from explorer, then get dumped in a v1 dashboard in view mode? then toggle edit mode if need be?

[graceguo-supercat]

editMode=true flag is set from explore view
https://github.com/apache/incubator-superset/blob/c18ef8903409c20b8526b9acd12d3ba1c4c3664b/superset/assets/src/explore/components/SaveModal.jsx#L111

i just feel it's too many hassle to bring this dashboard logic (preview? version1 ? version2?) to explore view.

[williaster]

all you have to do is delete { edit: 'true' }, we discussed that we just never want it to equal true.

[graceguo-supercat]

@williaster can you clarify this case:
During transition time, owner opens dashboard in V1, he will see promotion message to preview in V2, but he didn't save to v2 yet. If non-owner open this dashboard (and non-owner will see it in v1 version?), and tries to save-as, should we save the v1 version in V1 or V2?

[williaster]

I think if editing v1, saving should be v1 and if editing v2, saving should be v2.

[graceguo-supercat]

Owner can edit or save-as v1 or v2, as long he choose.
My question is for viewers: if a viewer does not own this dashboard, he can not edit (i mean edit and save the original dashboard). But if he wants to save-as a copy, which version should we save-as? you mean he should save the version he is viewing?

[williaster]

sorry if I wasn't clear enough, I already tried to answer that:

• if anyone (regardless of edit ability) is on the v1 view of the dashboard and they hit save as, it should be a v1 dashboard.
• if anyone (regardless of edit ability) is on the v2 view of the dashboard and they hit save as, it should be a v2 dashboard. (it's fine if this is an owner and they go to the v1 view, then if they save it there, it will be a v1 dashboard)

the most important thing is that the dashboard version should match whatever view it is upon save.

[williaster]

@graceguo-supercat can you add a comment about strings vs ints here so the logic is documented somewhere?

[graceguo-supercat]

in v2 dashboard position json, chartId is integer type:

"DASHBOARD_CHART_TYPE-H10M97Xk-7": {
        "children": [],
        "id": "DASHBOARD_CHART_TYPE-H10M97Xk-7",
        "meta": {
            "chartId": 136,
            "height": 50,
            "sliceName": "Treemap",
            "width": 8
        },
        "type": "DASHBOARD_CHART_TYPE"
    },

in older dashboard position json data, slice_id is string type:

   {
        "slice_id": "49", 
        "size_x": 8, 
        "size_y": 16, 
        "v": 1, 
        "col": 33, 
        "row": 24
    }, 

[williaster]

LGTM with one comment request!