Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sql lab] Fix issue around VARBINARY type in Presto #5121

Merged
merged 1 commit into from
Jun 20, 2018
Merged

[sql lab] Fix issue around VARBINARY type in Presto #5121

merged 1 commit into from
Jun 20, 2018

Commits on Jun 1, 2018

  1. [sql lab] Fix issue around VARBINARY type in Presto 

    When receiving a VARBINARY field out of Presto, it shows up as type
`bytes` out of the pyhive driver. Then the pre 3.15 version of
simplejson attempts to convert it to utf8 by default and it craps out.

I bumped to simplejson>=3.25.0 and set `encoding=None` as documented
here
https://simplejson.readthedocs.io/en/latest/#basic-usage so that we can
handle bytes on our own.
    @mistercrunch
    mistercrunch committed Jun 1, 2018
    Configuration menu
    Copy the full SHA
    1b10f5c View commit details
    Browse the repository at this point in the history