[sql_lab]Disabled run query button if sql query editor is empty #4728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lprashant-94
changed the title
Codecov Report
@@ Coverage Diff @@
## master #4728 +/- ##
==========================================
+ Coverage 72.22% 72.38% +0.15%
==========================================
Files 204 205 +1
Lines 15323 15374 +51
Branches 1180 1182 +2
==========================================
+ Hits 11067 11128 +61
+ Misses 4253 4243 -10
Partials 3 3
Continue to review full report at Codecov.
|
mistercrunch
requested changes
Apr 3, 2018
| @@ -43,6 +44,7 @@ export default function RunQueryActionButton(props) { | |||
| onClick={() => props.runQuery(true)} | |||
| key="run-async-btn" | |||
| tooltip={t('Run query asynchronously')} | |||
| disabled={!props.sql.trim()} | |||
There was a problem hiding this comment.
I'm confused as to why the linter isn't asking for sql to be in propTypes. I wanted to make sure it's entered as a string and can never be null through a defaultProps = ''
There was a problem hiding this comment.
I have made changes, please review 👍
|
I didn't understand your comment, can you please elaborate.
…On Tue 3 Apr, 2018, 10:13 AM Maxime Beauchemin, ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In superset/assets/javascripts/SqlLab/components/RunQueryActionButton.jsx
<#4728 (comment)>
:
> @@ -43,6 +44,7 @@ export default function RunQueryActionButton(props) {
onClick={() => props.runQuery(true)}
key="run-async-btn"
tooltip={t('Run query asynchronously')}
+ disabled={!props.sql.trim()}
I'm confused as to why the linter isn't asking for sql to be in propTypes.
I wanted to make sure it's entered as a string and can never be null
through a defaultProps = ''
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4728 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AWLeFKQiCQRRzNVaFtppGyPqfk1C2fpmks5tkv31gaJpZM4TCy38>
.
|
|
I got it, I will add propsType for sql as well, Thanks |
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
…he#4728) * Disabled run query button if sql query editor is empty * Removing unnecessary white space * Fix failing test for sql props * Adding sql variable into propTypes and defaultProps
timifasubaa
pushed a commit
to timifasubaa/incubator-superset
that referenced
this pull request
May 31, 2018
…he#4728) * Disabled run query button if sql query editor is empty * Removing unnecessary white space * Fix failing test for sql props * Adding sql variable into propTypes and defaultProps
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
…he#4728) * Disabled run query button if sql query editor is empty * Removing unnecessary white space * Fix failing test for sql props * Adding sql variable into propTypes and defaultProps
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
#2102
Disabled run button if sql query is empty.