Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] convert metrics to numeric in dataframe #4726

Merged
merged 3 commits into from
Apr 3, 2018
Merged

[bugfix] convert metrics to numeric in dataframe #4726

merged 3 commits into from
Apr 3, 2018

Commits on Mar 30, 2018

  1. [bugfix] convert metrics to numeric in dataframe 

    It appears sometimes the dbapi driver and pandas's read_sql fail at
returning the proper numeric types for metrics and they show up as
`object` in the dataframe. This results in "No numeric types to
aggregate" errors when trying to perform aggregations or pivoting in
pandas.

This PR looks for metrics in dataframes that are typed as "object"
and uses pandas' to_numeric to convert.
    @mistercrunch
    mistercrunch committed Mar 30, 2018
    Configuration menu
    Copy the full SHA
    5e79677 View commit details
    Browse the repository at this point in the history

  2. Fix tests

    @mistercrunch
    mistercrunch committed Mar 30, 2018
    Configuration menu
    Copy the full SHA
    f6471a8 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2018

  1. Remove all iteritems

    @mistercrunch
    mistercrunch committed Apr 2, 2018
    Configuration menu
    Copy the full SHA
    32a03cb View commit details
    Browse the repository at this point in the history