Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[explore] proper filtering of NULLs and '' #4651

Merged
merged 8 commits into from
Apr 18, 2018
Merged

[explore] proper filtering of NULLs and '' #4651

merged 8 commits into from
Apr 18, 2018

Commits on Apr 18, 2018

  1. [WiP] [explore] proper filtering of NULLs and '' 

    TODO: handling of Druid equivalents
    @mistercrunch
    mistercrunch committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    e4b449d View commit details
    Browse the repository at this point in the history

  2. Unit tests

    @mistercrunch
    mistercrunch committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    a66801d View commit details
    Browse the repository at this point in the history

  3. Some refactoring

    @mistercrunch
    mistercrunch committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    6e74170 View commit details
    Browse the repository at this point in the history

  4. [druid] fix 'Unorderable types' when col has nuls 

    Error "unorderable types: str() < int()" occurs when grouping by a
numerical Druid colummn that contains null values.

* druid/pydruid returns strings in the datafram with NAs for nulls
* Superset has custom logic around get_fillna_for_col that fills in the
NULLs based on declared column type (FLOAT here), so now we have a mixed
bag of type in the series
* pandas chokes on pivot_table or groupby operations as it cannot sorts
mixed types

The approach here is to stringify and fillna('<NULL>') to get a
consistent series.
    @mistercrunch
    mistercrunch committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    04bc892 View commit details
    Browse the repository at this point in the history

  5. typo

    @mistercrunch
    mistercrunch committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    289b5aa View commit details
    Browse the repository at this point in the history

  6. Fix druid_func tests

    @mistercrunch
    mistercrunch committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    ffe30a1 View commit details
    Browse the repository at this point in the history

  7. Addressing more comments

    @mistercrunch
    mistercrunch committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    01aa3a2 View commit details
    Browse the repository at this point in the history

  8. last touches

    @mistercrunch
    mistercrunch committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    741832e View commit details
    Browse the repository at this point in the history