Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding to list of generated-members to fix pylint errors #4632

Merged

Conversation

michellethomas
Copy link
Contributor

Trying to fix the travis issues

@michellethomas michellethomas force-pushed the fix_pylint_scoped_session_errors branch from 9795ef5 to 19b6b73 Compare March 16, 2018 21:11
@michellethomas
Copy link
Contributor Author

@mistercrunch @john-bodley @graceguo-supercat this pr fixes the current pylint issues. LMK if you think there's a better way, when googling around this seemed to be the recommended approach.

@codecov-io
Copy link

codecov-io commented Mar 16, 2018

Codecov Report

Merging #4632 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4632      +/-   ##
==========================================
+ Coverage   71.17%   71.22%   +0.04%     
==========================================
  Files         189      190       +1     
  Lines       14848    14880      +32     
  Branches     1087     1098      +11     
==========================================
+ Hits        10568    10598      +30     
- Misses       4277     4279       +2     
  Partials        3        3
Impacted Files Coverage Δ
...set/assets/javascripts/explore/stores/controls.jsx 37.59% <0%> (-0.58%) ⬇️
...set/assets/javascripts/components/ColumnOption.jsx 100% <0%> (ø) ⬆️
...set/assets/javascripts/components/MetricOption.jsx 100% <0%> (ø) ⬆️
.../assets/javascripts/components/ColumnTypeLabel.jsx 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6875868...39cc97c. Read the comment docs.

@john-bodley john-bodley merged commit 97afcd5 into apache:master Mar 16, 2018
michellethomas added a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
* Adding to list of generated-members

* Updating to ignore-classes sqlalchemy scoped_session
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
* Adding to list of generated-members

* Updating to ignore-classes sqlalchemy scoped_session
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.24.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.24.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants