[slice_json] pass slice id to get_form_data() #4607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4607 +/- ##
=========================================
+ Coverage 71.18% 72.08% +0.9%
=========================================
Files 189 189
Lines 14847 15512 +665
Branches 1086 1086
=========================================
+ Hits 10569 11182 +613
- Misses 4275 4327 +52
Partials 3 3
Continue to review full report at Codecov.
|
| datasource_type = viz_obj.datasource.type | ||
| datasource_id = viz_obj.datasource.id | ||
| form_data, slc = self.get_form_data() | ||
| form_data, slc = self.get_form_data(slice_id) |
There was a problem hiding this comment.
Does the overriding, e.g. since and until still work?
There was a problem hiding this comment.
yeah I talked to @graceguo-supercat about get_form_data and it's supposed to encapsulate all of the logic for form data + overrides. you can see on this line that it will override the saved slice params with any in the request
fabianmenges
approved these changes
Mar 13, 2018
|
LGTM! |
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Mar 15, 2018
(cherry picked from commit 95a9b04)
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mistercrunch @graceguo-supercat @fabianmenges
This line of #4490 broke all non-formula type annotations as it didn't pass the
slice_idthrough toget_form_data()before:
after:
