Fix markup broken since cache related changes #4396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚢 |
|
@mistercrunch I believe this PR may have introduced a regression. We now see which is more informative. |
|
Also seeing the general |
|
We should add a unit test that covers that proper error message. |
|
@mistercrunch would you mind proving more context for the reason of this PR so we can further debug and provide a fix with the appropriate unit tests. |
john-bodley
pushed a commit
to john-bodley/superset
that referenced
this pull request
Feb 28, 2018
john-bodley
added a commit
that referenced
this pull request
Mar 6, 2018
[bugfix] Fixing regression introduced in #4396
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
[bugfix] Fixing regression introduced in apache#4396
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@graceguo-supercat I mentioned this when we spoke today. It needs to be bundled along other caching-related changes