Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 4 security vulnerabilities #4390

Merged
merged 6 commits into from
Feb 9, 2018
Merged

Commits on Feb 8, 2018

  1. Switched yaml.load to yaml.safe_load to prevent code execution via cr…

    …afted yaml files
    
    Python's yaml.laod can lead to code execution via crafted yaml files such as:
    
    ```
    code_exec: !!python/object/apply:subprocess.check_output ['ls']
    ```
    ddworken-sc committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    7e949ee View commit details
    Browse the repository at this point in the history
  2. Fixed XSS via bleach

    It was possible to get an XSS via the markdown library via simply setting a description containing arbitary HTML tags.
    It was also possible to create links that went to the `javascript:` link handler (eg `[example](javascript:alert(0)`)
    Using bleach to sanitize it solves both of these.
    ddworken-sc committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    b6fcc22 View commit details
    Browse the repository at this point in the history
  3. Added XFO header by default to prevent clickjacking attacks

    Note that with this application clickjacking can be relatively severe via the SQLLab functionality
    which allows executing arbitary SQL.
    ddworken-sc committed Feb 8, 2018
    Configuration menu
    Copy the full SHA
    f113d2b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6f00074 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2018

  1. Fixed linting errors

    ddworken-sc committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    31c00f1 View commit details
    Browse the repository at this point in the history
  2. Fixed linting errors

    ddworken-sc committed Feb 9, 2018
    Configuration menu
    Copy the full SHA
    164ac1f View commit details
    Browse the repository at this point in the history