Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve deck.gl GeoJSON visualization #4220

Merged
merged 3 commits into from
Jan 17, 2018
Merged

Improve deck.gl GeoJSON visualization #4220

merged 3 commits into from
Jan 17, 2018

Conversation

mistercrunch
Copy link
Member

  • support nested FeatureCollection
  • add support for javascript controls
  • getting rid of get_position in BaseDeckGLViz and derivatives

hughhhh
hughhhh reviewed Jan 17, 2018
View reviewed changes
superset/assets/visualizations/deckgl/layers/geojson.jsx Outdated
recurseGeoJson(obj, propOverrides, jsFnMutator, node.extraProps || extraProps);
});
}
if (node && node.properties) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think checking for geometry instead of properties would be better here. Not all nodes need the property set, but the geometry is mandatory for defining the shape.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call

hughhhh
hughhhh reviewed Jan 17, 2018
View reviewed changes
superset/assets/visualizations/deckgl/layers/geojson.jsx
if (node && node.geometry) {
const newNode = {
...node,
properties: alterProps(node.properties, propOverrides),
Copy link
Member

@hughhhh hughhhh Jan 17, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: properties: (node.properties) ? alterProps(node.properties, propOverrides) : {}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overrides wouldn't apply in that case. It'd have to be (node.properties || Object.keys(propOverrides).length > 0) or something, but that would give the same result. I'll just leave it as is as it's more readable.

@hughhhh
Copy link
Member

hughhhh commented Jan 17, 2018

LGTM w/ nit

@mistercrunch

@mistercrunch mistercrunch merged commit 01043c9 into apache:master Jan 17, 2018
@mistercrunch mistercrunch deleted the improve_geojson branch January 17, 2018 22:01
mistercrunch pushed a commit that referenced this pull request Jan 18, 2018
@hughhhh @mistercrunch
Added DeckGL.Polygon Layer w/ JS controls (#4227)
5079b2a 
* Working polygon layer for deckGL

* add js controls

* add thumbnail

* better description

* refactor to leverage line_column controls

* templates: open code and documentation on a new tab (#4217)

As they are external resources.

* Fix tutorial doesn't match the current interface #4138 (#4215)

* [bugfix] markup and iframe viz raise 'Empty query' (#4225)

closes #4222

Related to: #4016

* [bugfix] time_pivot entry got missing in merge conflict (#4221)

PR here #3518 missed a
line of code while merging conflicts with time_pivot viz

* Improve deck.gl GeoJSON visualization (#4220)

* Improve geoJSON

* Addressing comments

* lint

* refactor to leverage line_column controls

* refactor to use DeckPathViz

* oops
hughhhh pushed a commit to lyft/incubator-superset that referenced this pull request Jan 18, 2018
@mistercrunch @hughhhh
Improve deck.gl GeoJSON visualization (apache#4220)
af94173 
* Improve geoJSON

* Addressing comments

* lint
hughhhh added a commit to lyft/incubator-superset that referenced this pull request Jan 18, 2018
@hughhhh
Added DeckGL.Polygon Layer w/ JS controls (apache#4227)
1c76d58 
* Working polygon layer for deckGL

* add js controls

* add thumbnail

* better description

* refactor to leverage line_column controls

* templates: open code and documentation on a new tab (apache#4217)

As they are external resources.

* Fix tutorial doesn't match the current interface apache#4138 (apache#4215)

* [bugfix] markup and iframe viz raise 'Empty query' (apache#4225)

closes apache#4222

Related to: apache#4016

* [bugfix] time_pivot entry got missing in merge conflict (apache#4221)

PR here apache#3518 missed a
line of code while merging conflicts with time_pivot viz

* Improve deck.gl GeoJSON visualization (apache#4220)

* Improve geoJSON

* Addressing comments

* lint

* refactor to leverage line_column controls

* refactor to use DeckPathViz

* oops
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
@mistercrunch @michellethomas
Improve deck.gl GeoJSON visualization (apache#4220)
e86a11c 
* Improve geoJSON

* Addressing comments

* lint
michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
@hughhhh @michellethomas
Added DeckGL.Polygon Layer w/ JS controls (apache#4227)
1356943 
* Working polygon layer for deckGL

* add js controls

* add thumbnail

* better description

* refactor to leverage line_column controls

* templates: open code and documentation on a new tab (apache#4217)

As they are external resources.

* Fix tutorial doesn't match the current interface apache#4138 (apache#4215)

* [bugfix] markup and iframe viz raise 'Empty query' (apache#4225)

closes apache#4222

Related to: apache#4016

* [bugfix] time_pivot entry got missing in merge conflict (apache#4221)

PR here apache#3518 missed a
line of code while merging conflicts with time_pivot viz

* Improve deck.gl GeoJSON visualization (apache#4220)

* Improve geoJSON

* Addressing comments

* lint

* refactor to leverage line_column controls

* refactor to use DeckPathViz

* oops
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch
Improve deck.gl GeoJSON visualization (apache#4220)
483da58 
* Improve geoJSON

* Addressing comments

* lint
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@hughhhh @mistercrunch
Added DeckGL.Polygon Layer w/ JS controls (apache#4227)
3482bce 
* Working polygon layer for deckGL

* add js controls

* add thumbnail

* better description

* refactor to leverage line_column controls

* templates: open code and documentation on a new tab (apache#4217)

As they are external resources.

* Fix tutorial doesn't match the current interface apache#4138 (apache#4215)

* [bugfix] markup and iframe viz raise 'Empty query' (apache#4225)

closes apache#4222

Related to: apache#4016

* [bugfix] time_pivot entry got missing in merge conflict (apache#4221)

PR here apache#3518 missed a
line of code while merging conflicts with time_pivot viz

* Improve deck.gl GeoJSON visualization (apache#4220)

* Improve geoJSON

* Addressing comments

* lint

* refactor to leverage line_column controls

* refactor to use DeckPathViz

* oops
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.23.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hughhhh hughhhh hughhhh left review comments

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.23.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mistercrunch @hughhhh