Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding limit to time_table viz to get druid query to work #4207

Merged

Conversation

michellethomas
Copy link
Contributor

@michellethomas michellethomas commented Jan 12, 2018

@graceguo-supercat @john-bodley Adding the limit control on the time series table visualization.

[Update] Pulled out the description for the issue here. In short, the druid query for the time series table was incorrect because it required a limit to include the second part of the query.

I'm not as familiar with this part of the code so I'm just adding a temporary fix to get the time table viz working. But this also causes problems if you remove the limit on a line chart.

Copy link

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@graceguo-supercat graceguo-supercat merged commit 2607e4b into apache:master Jan 16, 2018
@michellethomas michellethomas deleted the time_series_add_limit branch January 16, 2018 18:27
hughhhh pushed a commit to lyft/incubator-superset that referenced this pull request Jan 18, 2018
john-bodley pushed a commit to airbnb/superset-fork that referenced this pull request Jan 18, 2018
john-bodley pushed a commit to john-bodley/superset that referenced this pull request Jan 19, 2018
john-bodley added a commit to airbnb/superset-fork that referenced this pull request Jan 19, 2018
Adding limit to time_table viz to get druid query to work (apache#4207)
john-bodley added a commit to airbnb/superset-fork that referenced this pull request Jan 19, 2018
john-bodley pushed a commit to airbnb/superset-fork that referenced this pull request Jan 19, 2018
michellethomas added a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.23.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.23.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants