Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix raise error when query datasource #3298

Merged
merged 4 commits into from
Aug 16, 2017

Conversation

roganw
Copy link
Contributor

@roganw roganw commented Aug 16, 2017

Optimize the code by changing the db.session.query()... method to call get_datasource().
And fix the error in line: 1056 and line: 2003, query using one(), which will raise sqlalchemy.orm.exc.NoResultFound if the query selects no rows.

@coveralls
Copy link

coveralls commented Aug 16, 2017

Coverage Status

Coverage decreased (-0.009%) to 69.41% when pulling bd48a9c on RoganW:fix_datasource_raise_error into 232a5c3 on apache:master.

@mistercrunch mistercrunch merged commit d1d1c49 into apache:master Aug 16, 2017
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.19.1 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.19.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants