Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WiP][explore] metrics as popovers #3202

Closed
wants to merge 4 commits into from
Closed

[WiP][explore] metrics as popovers #3202

wants to merge 4 commits into from

Conversation

mistercrunch
Copy link
Member

screen shot 2017-07-28 at 2 42 30 pm

@john-bodley
Copy link
Member

@mistercrunch it seems these metrics don't persist in the DB so the state is local, and thus one couldn't share the URL with others. Is this correct?

@mistercrunch
Copy link
Member Author

These are local to the Slice. Radio button #2 represents the list of predefined metrics as they exist now.

@williaster
Copy link
Contributor

@mistercrunch would that be problematic for sharing urls that refer to these types of metrics? what would happen in that case? would an error be thrown?

@mistercrunch
Copy link
Member Author

@williaster the metric definition is just part of the formData meaning it's in the URL

@mistercrunch
Copy link
Member Author

Superseeded by #4663

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mistercrunch @john-bodley @williaster