Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Celery] fix the celery worker concurrency settings #3126

Merged
merged 1 commit into from
Jul 14, 2017

Conversation

dingguitao
Copy link
Contributor

From the celery documentation, lower case settings and setting organization were introduced since version 4.0. Superset is still using version 3.x. So we can use upper case settings or upgrade celery to 4.x version.

@dingguitao
Copy link
Contributor Author

dingguitao commented Jul 14, 2017

Fix #3125

@xrmx
Copy link
Contributor

xrmx commented Jul 14, 2017

Next time no need to open an issue if you are opening a PR please.

@mistercrunch
Copy link
Member

Thank you for this. I had upgraded to Celery 4.0 but had to roll back because of some issue in our environment. When rolling back I forgot to backtrack on the configuration change.

We're planning on upgrading when that issue is fixed. I should provide a link to the issue here for reference but don't have time just now to dig it out.

@mistercrunch mistercrunch merged commit 256a521 into apache:master Jul 14, 2017
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.19.0 labels Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.19.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants