chore: enable lint PT009 'use regular assert over self.assert.*' #30521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I just got bit by some old school self.assertEqual which is not good as the pytest-augmented, simple assert. Just leveraging the rule, running automated --fix for things it can fix and adding NOQA to the few it didn't auto-fix
michael-s-molina
requested review from
michael-s-molina,
betodealmeida and
villebro
villebro
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just got bit by some old school self.assertEqual which is not good as the pytest-augmented, simple assert. Just leveraging the rule, running automated --fix for things it can fix and adding NOQA to the few it didn't auto-fix