fix(sqllab): Remove redundant scrolling #30500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -940,12 +945,14 @@ const SqlEditor: FC<Props> = ({ | |||
| minWidth={SQL_EDITOR_LEFTBAR_WIDTH} | |||
| initialWidth={SQL_EDITOR_LEFTBAR_WIDTH} | |||
| enable={!hideLeftBar} | |||
| padding={leftBarPadding} | |||
There was a problem hiding this comment.
@justinpark Why does a left bar padding influences on a wrapper height? If it was a top/bottom padding, I would understand but a left one?
There was a problem hiding this comment.
If this variable mean that a top padding is applied when the left bar is open, then it would be a good idea to rename the variable to make it more clear.
michael-s-molina
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This commit fixes the redundant vertical scrolling in SQL Lab caused by the bottom resize handlers, which are not used for the sidebar resizer.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
before--scrolling.mov
After:
after--scrolling.mov
TESTING INSTRUCTIONS
Go to SQL Lab and then check the scrollbar in the query panel.
ADDITIONAL INFORMATION