Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update no select following review #30499

Closed
wants to merge 26 commits into from
Closed

Update no select following review #30499

wants to merge 26 commits into from

Conversation

MialLewis
Copy link

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

MialLewis and others added 26 commits July 31, 2024 15:21
@MialLewis
disable data selection from results table
a15cc8c
@MialLewis
disable selection from chart table
2a58dd7
@MialLewis
disable pivot chart select
62f5b00
@MialLewis
add user select to permissions model
ca17002
@MialLewis
change perms to can_export_csv
06a44d8
@MialLewis
pass dataSelectionMode prop to plugin
71018c8
@MialLewis
remove unneeded prop
703e7ef
@MialLewis
get permissions from role TableChart
fafe95b
@MialLewis
add user permissions to pivot table
27d22d1
@MialLewis
apply linter and fix compiler errors
6b35723
@MialLewis
update permissions to inline with previous features
6156e5f
@MialLewis
fix filterable table test
4b16a68
@bcook-konza
Merge pull request #1 from MialLewis/disable_data_selection_konza
1f7ff0e 
Disable data selection
@MialLewis
move access to redux state outside of filterable table comp
b7a785d
@MialLewis
move state query to DashboardBuilder
0ef5633
@MialLewis
revert redundant changes to filt table test
5d66273
@MialLewis
ammend transform props test
bb67c04
@MialLewis
remove unneeded import
fa24412
@MialLewis
access state from explorechartpanel
0df6fef
@MialLewis
correct chart props
45732ad
@MialLewis
remove canExportData from DashboardBuilder and component, pass in fro…
fef1e90 
…m gridConponents/chart
@MialLewis
run prettier
38215d2
@MialLewis
remove unneeded test change
7e2e1fa
@MialLewis
remove redundant filt table test var
8a31bf2
@MialLewis
update buildQuery test with DataSelectionMode
7d7f5f7
@MialLewis
Merge branch 'master' into update_no_select_following_review
aa02fc6
@MialLewis MialLewis closed this Oct 2, 2024
@dosubot dosubot bot added viz:charts:pivot Related to the Pivot Table charts viz:charts:table Related to the Table chart labels Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
packages plugins size/M viz:charts:pivot Related to the Pivot Table charts viz:charts:table Related to the Table chart
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MialLewis @bcook-konza