Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix broken links in CI #30496

Merged
merged 2 commits into from
Oct 2, 2024
Merged

docs: fix broken links in CI #30496

merged 2 commits into from
Oct 2, 2024

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Oct 1, 2024

^^^ title, CI link validator was firing with those links

Seen on another PR ->
Screenshot 2024-10-01 at 4 32 11 PM

@dosubot dosubot bot added the doc Namespace | Anything related to documentation label Oct 1, 2024
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!!

@rusackas
Copy link
Member

rusackas commented Oct 2, 2024

I think that's the first time I've seen HTTP code 999 in the wild. That's pretty interesting. I'll look at the other failing links and open another PR soon to clean up some of this stuff. I think there's also more work to do that it's not parsing and checking relative links in the markdown files, but I/we can improve that soon.

@rusackas rusackas merged commit bc8e951 into master Oct 2, 2024
36 of 37 checks passed
@michael-s-molina michael-s-molina added review:checkpoint Last PR reviewed during the daily review standup and removed review:checkpoint Last PR reviewed during the daily review standup labels Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Namespace | Anything related to documentation preset-io size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants